Fix duplicate _seconds suffix in APM latency metric name#6657
Merged
graytaylor0 merged 1 commit intoMar 20, 2026
Conversation
The Prometheus sink appends unit suffixes to metric names (e.g., unit "s" becomes "_seconds"). The APM service map processor was naming the histogram metric "latency_seconds" with unit "s", resulting in "latency_seconds_seconds" when exported to Prometheus. Rename the metric to "latency" so the final Prometheus metric name is correctly "latency_seconds". Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsimanohar
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
graytaylor0
approved these changes
Mar 19, 2026
ps48
approved these changes
Mar 19, 2026
Member
|
Built this change locally and checked the naming change works! Thanks @vamsimanohar @graytaylor0 Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"s"→_seconds)latency_secondswith unit"s", resulting inlatency_seconds_secondswhen exported to Prometheuslatencyso the final Prometheus metric name is correctlylatency_secondsTest plan
ApmServiceMapMetricsUtilTestandOTelApmServiceMapProcessorTest